chore: Change theme global selector from :root to body #3957
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed CSS theme selectors from :root to body in style-dictionary files across all theme config modules to ensure proper theme application once seed and reference token generation is added to theming-core.
We won't be resolving reference tokens to their hex value until the end of the resolution chain to allow for theming at a global level without having to replace every token value (300+ tokens). Because we are keeping the references as css values, :root has a higher specificity that doesn't allow the resolution to complete when there are multiple themes applied (primary, secondary). Using body as a global selector fixes the specificity issues.
Pre-req: theming-core PR to be in live.
Related links, issue #, if available: [ac9YAbqsd7e6], [CR-229505364]
How has this been tested?
Dev pipeline: Awsui-v3-jkuelz
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.