chore: Add new Box variant for inline-code #3879
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3879 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 850 850
Lines 24785 24772 -13
Branches 8735 8732 -3
=======================================
- Hits 24082 24070 -12
+ Misses 696 653 -43
- Partials 7 49 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
at-susie
requested review from
avinashbot
and removed request for
ernst-dev
at-susie
requested review from
avinashbot and
just-boris
and removed request for
avinashbot
| <div> | ||
| <Table<TableItem> | ||
| totalItemsCount={4} | ||
| renderAriaLive={({ firstIndex, lastIndex, totalItemsCount }: TableProps.LiveAnnouncement) => |
There was a problem hiding this comment.
This should not be needed
| renderAriaLive={({ firstIndex, lastIndex, totalItemsCount }: TableProps.LiveAnnouncement) => | |
| renderAriaLive={({ firstIndex, lastIndex, totalItemsCount }) => |
There was a problem hiding this comment.
Thank you @just-boris for the feedback. I integrated all the recommendations in this commit
| { | ||
| id: 'variable', | ||
| header: 'Variable name', | ||
| cell: (item: TableItem) => <Link href="#">{item.name || '-'}</Link>, |
There was a problem hiding this comment.
Same for all arguments in the table props
| cell: (item: TableItem) => <Link href="#">{item.name || '-'}</Link>, | |
| cell: (item) => <Link href="#">{item.name || '-'}</Link>, |
There was a problem hiding this comment.
I integrated this in this commit
…esign/components into inline-code-variant
| expect(findClose(wrapper).getElement()).not.toHaveAttribute('aria-label'); | ||
| }); | ||
|
|
||
| test('Opens and closes drawer in uncontrolled mode', () => { |
There was a problem hiding this comment.
Something wrong happened with app layout folder. These files were not supposed to change, right?
There was a problem hiding this comment.
No, these files were not supposed to change. I rebased this my branch this morning that might cause this.
I will create a new clean PR.
|
released #3931 |
4 participants
Description
We identified the lack of a consistent visual style for inline code elements across services. In the absence of a standardized approach, teams have implemented custom styles, resulting in visual inconsistencies.
This PR introduces a new variant in Box component called awsui-inline-code, which can be used to display a unified style for inline-code elements.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.