Skip to content

Conversation

abdhalees
Copy link
Member

@abdhalees abdhalees commented Jul 1, 2025

Description

  • Add a dismiss function to Popover
  • Update description of foucs function
  • Remove internal popover ref types since all functions are exposed now.

Related links, issue #, if available: OnN0ALyeaaYh

How has this been tested?

Unit test

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (76a1204) to head (fb6bd91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3631    +/-   ##
========================================
  Coverage   96.61%   96.61%            
========================================
  Files         813      813            
  Lines       23700    23700            
  Branches     8243     7887   -356     
========================================
  Hits        22898    22898            
- Misses        748      795    +47     
+ Partials       54        7    -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@abdhalees abdhalees marked this pull request as ready for review July 8, 2025 10:09
@abdhalees abdhalees requested a review from a team as a code owner July 8, 2025 10:09
@abdhalees abdhalees requested review from gethinwebster and removed request for a team July 8, 2025 10:09
@abdhalees abdhalees enabled auto-merge July 8, 2025 10:48
@abdhalees abdhalees requested a review from gethinwebster July 8, 2025 13:10
@abdhalees abdhalees added this pull request to the merge queue Jul 9, 2025
Merged via the queue into main with commit f40e0fc Jul 9, 2025
93 of 96 checks passed
@abdhalees abdhalees deleted the dismiss-popover branch July 9, 2025 07:50
pranshuteotia pushed a commit to pranshuteotia/components that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants