Skip to content

Conversation

timogasda
Copy link
Member

@timogasda timogasda commented Jun 25, 2025

Description

This PR removes the top navigation beta code, which has been replaced by the stable top navigation component in 2022.

It also removes the "idea" of beta components (listBetaVersions), since this was the only beta component and we currently no plans to bring this idea back.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (8fa9df2) to head (a229124).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
+ Coverage   96.62%   96.92%   +0.30%     
==========================================
  Files         818      812       -6     
  Lines       23799    23565     -234     
  Branches     8354     8177     -177     
==========================================
- Hits        22996    22841     -155     
+ Misses        749      674      -75     
+ Partials       54       50       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timogasda timogasda force-pushed the gasda/remove-topnav-beta branch from 94803c4 to a229124 Compare July 22, 2025 10:10
@timogasda timogasda marked this pull request as ready for review July 22, 2025 10:10
@timogasda timogasda requested a review from a team as a code owner July 22, 2025 10:10
@timogasda timogasda requested review from teodoranemes and removed request for a team July 22, 2025 10:10
Copy link
Member

@avinashbot avinashbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@timogasda timogasda added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit 9e83d9a Aug 1, 2025
38 checks passed
@timogasda timogasda deleted the gasda/remove-topnav-beta branch August 1, 2025 03:56
pranshuteotia pushed a commit to pranshuteotia/components that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants