chore: Refactor dropdown test utils #3571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3571 +/- ##
==========================================
+ Coverage 96.60% 96.62% +0.02%
==========================================
Files 807 807
Lines 23572 23555 -17
Branches 8196 8254 +58
==========================================
- Hits 22771 22761 -10
- Misses 747 787 +40
+ Partials 54 7 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jperals
force-pushed
the
chore/refactor-dropdown-host
branch
from
9dd63f8 to
de9ff21
Compare
jperals
commented
Jun 12, 2025
| export class DropdownContentWrapper extends ComponentWrapper { | ||
| export class BaseDropdownContentWrapper extends ComponentWrapper { | ||
| /** | ||
| * Returns all the disabled options. |
There was a problem hiding this comment.
The original doc text here for the AutosuggestDropdownWrapper was "Returns all the selected options.", which must have been wrong.
jperals
force-pushed
the
chore/refactor-dropdown-host
branch
2 times, most recently
from
2e756ff to
7001d75
Compare
jperals
force-pushed
the
chore/refactor-dropdown-host
branch
from
7001d75 to
6d50919
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AutosuggestDropdownWrapper and DropdownContentWrapper share a good number of methods which are currently identical. This PR deduplicates them via a third base class so that future updates such as #3570 are simpler and make sure they do not eventually lead to diverging implementations.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.