Skip to content

Conversation

cansuaa
Copy link
Member

@cansuaa cansuaa commented May 6, 2025

Description

This PR adds the tree-view component.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 97.91667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.62%. Comparing base (f40e0fc) to head (11cd9ed).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/tree-view/tree-item/index.tsx 93.54% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3477    +/-   ##
========================================
  Coverage   96.61%   96.62%            
========================================
  Files         813      817     +4     
  Lines       23700    23793    +93     
  Branches     7887     8341   +454     
========================================
+ Hits        22898    22989    +91     
+ Misses        795      750    -45     
- Partials        7       54    +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -14,11 +14,15 @@ export function ExpandToggleButton({
onExpandableItemToggle,
expandButtonLabel,
collapseButtonLabel,
customIcon,
hasLargeFocusOffset,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it was a deliberate decision. I think if a larger outline offset does look ok in the table, too - we don't need to create an extra prop. It also makes sense that both toggle components look similar.

pan-kot
pan-kot previously approved these changes Jul 8, 2025
@cansuaa cansuaa removed the request for review from avinashbot July 10, 2025 09:41
@cansuaa cansuaa added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit b1e909b Jul 10, 2025
38 checks passed
@cansuaa cansuaa deleted the cansua/treeview branch July 10, 2025 10:02
pranshuteotia pushed a commit to pranshuteotia/components that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants