Skip to content

chore: Update selection events analytics metadata #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

fralongo
Copy link
Member

Description

Currently select (and similar) events are being post-processed by the analytics team to rename them to deselect if selected=false. This saves storage for events database tables.

Changing this will align with the actual usage.

How has this been tested?

Updated unit tests, and added more

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates. N/A
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md. Yes, the Analytics team logic already supports the new native format.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md. N/A
  • Changes were manually tested for accessibility, see accessibility guidelines. N/A

Security

Testing

  • Changes are covered with new/existing unit tests? Yes
  • Changes are covered with new/existing integration tests? N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fralongo fralongo requested a review from a team as a code owner April 28, 2025 14:29
@fralongo fralongo requested review from ernst-dev and removed request for a team April 28, 2025 14:29
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (fb1c43d) to head (b96a1bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3458   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         806      806           
  Lines       23089    23090    +1     
  Branches     7923     7995   +72     
=======================================
+ Hits        22280    22281    +1     
  Misses        755      755           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fralongo fralongo added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit 6c2c946 Apr 29, 2025
38 checks passed
@fralongo fralongo deleted the flongo-select-metadata-update branch April 29, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants