chore: Widgetize flashbar #3334
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Mar 6, 2025
| const isReducedMotion = useReducedMotion(ref); | ||
| const isVisualRefresh = useVisualRefresh(); |
There was a problem hiding this comment.
Moved isVisualRefresh from the hook directly into component code to make DCE work for ALWAYS_VISUAL_REFRESH mode
just-boris
commented
Mar 6, 2025
Comment on lines
-28
to
-30
| const { __internalRootRef } = useBaseComponent('Flashbar', { | ||
| props: { stackItems: restProps.stackItems }, | ||
| }); |
There was a problem hiding this comment.
Moved it into the flashbar/index.tsx file to make this hook run before the widget loaded
just-boris
force-pushed
the
widgetize-flashbar
branch
from
f36295b to
45bc6af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3334 +/- ##
========================================
Coverage 96.44% 96.44%
========================================
Files 795 797 +2
Lines 22701 22708 +7
Branches 7425 7774 +349
========================================
+ Hits 21893 21900 +7
+ Misses 801 754 -47
- Partials 7 54 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
just-boris
force-pushed
the
widgetize-flashbar
branch
from
45bc6af to
24e30e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make flashbar component to load via widget
Related links, issue #, if available: n/a
How has this been tested?
Tests in my dev pipelines
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.