fix: Do not render tooltip descriptions if set to null #57
+34
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperals
commented
Jul 8, 2025
| @@ -31,7 +31,7 @@ describe("CartesianChart: errorbar series", () => { | |||
| expect(getAllTooltipSeries()).toHaveLength(1); | |||
| expect(getTooltipSeries(0).findKey().getElement().textContent).toBe("Column 1"); | |||
| expect(getTooltipSeries(0).findValue().getElement().textContent).toBe("2"); | |||
| expect(getTooltipSeries(0).findDescription().getElement().textContent).toBe("Error range1 - 3"); | |||
| expect(getTooltipSeries(0).findDescription()!.getElement().textContent).toBe("Error range1 - 3"); | |||
There was a problem hiding this comment.
Before, the ! were not necessary because the description could never be empty, but it should be able to.
pan-kot
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows to override the default error ranges in the descriptions and group them in the tooltip footer instead.
Rel:
6wXLAG4Wx5eV(see e.g, "Displaying nothing" section)How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.