Skip to content

Separating the create_transit_gateway_route_table_association_and_propagation variable into 3 variables #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Separating the create_transit_gateway_route_table_association_and_propagation variable into 3 variables #55

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 10, 2024

what

Separating the create_transit_gateway_route_table_association_and_propagation variable into 3 variables

  • create_transit_gateway_route_table_association
  • create_transit_gateway_route_table_propagation
  • create_transit_gateway_routes

why

Allows for more flexibility when

  • deploying multi-account examples
  • when multiple route tables are needed
  • propagation is not desired (centralized egress and prevent VPC-to-VPC communication) but association still is

references

Keith Loveday added 2 commits December 10, 2024 09:25
Update variables.tf
a0cdec6 
Separate create propagation, association, route vars
Update main.tf
3170d2e 
Update create var usage
@ghost ghost requested review from a team as code owners December 10, 2024 14:33
@ghost ghost requested review from johncblandii and gberenice December 10, 2024 14:33
@mergify mergify bot added the triage Needs triage label Dec 10, 2024
@ghost ghost changed the title Kloveday2 patch 1 Separating the create_transit_gateway_route_table_association_and_propagation variable into 3 variables Dec 10, 2024
@ghost ghost marked this pull request as draft December 10, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@gberenice gberenice Awaiting requested review from gberenice gberenice is a code owner automatically assigned from cloudposse/contributors

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants