Skip to content

Switch to pixels #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aatanasov-cloudinary merged 1 commit into from
Jan 14, 2026
Merged

Switch to pixels #1119

aatanasov-cloudinary merged 1 commit into from
Jan 14, 2026

Conversation

@aatanasov-cloudinary
Copy link
Collaborator

@aatanasov-cloudinary aatanasov-cloudinary commented Jan 14, 2026 •
edited
Loading

After testing the Image Effects, it was decided to proceed first with pixels. In this PR, we revert the offset and size fields to pixels. Also, an issue with the edit asset page was fixed.

Approach

  • Prepared the fields to use pixels.
  • Added a slug to the edit_page settings.

QA notes

  • Go to the edit effects page of an asset and ensure the effect can be configured using pixels
  • Ensure the front-end renders the effects correctly.

@aatanasov-cloudinary aatanasov-cloudinary merged commit 490d883 into develop Jan 14, 2026
5 checks passed
This was referenced Jan 14, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielcld2 gabrielcld2 Awaiting requested review from gabrielcld2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aatanasov-cloudinary @aatanasovdev