Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize SimpleSAMLPhp for Local Integration Tests #3272

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

fhanik
Copy link
Contributor

@fhanik fhanik commented Feb 4, 2025

This PR

  1. Creates a docker container for SimpleSAMLPHP that launches on localhost:9090
  2. Allows tests to be run using -Dintegration.test.saml.url=http://localhost:9090/simplesaml

Notes:

  • As of now, uaa-acceptance is running an older version of SimpleSAMLPhp, so the code has to take that into account. Once we have upgraded that, there are some simple if-then-else statements that can be removed

  • We are working towards the ability to run all tests on a developer workstation. We have completed MySQL, PostgreSQL, OpenLDAP and now with this SAML. Only thing missing are our OIDC10 tests

  • The authsources.php and saml20-sp-remote.php files are taken from our original SimpleSAMLPhp deployment under github user cf-identity

@fhanik fhanik force-pushed the pr/saml-via-docker branch from a3b8b28 to 3c38672 Compare February 4, 2025 20:44
@fhanik fhanik changed the title Pr/saml via docker Dockerize SimpleSAMLPhp for Local Integration Tests Feb 4, 2025
@fhanik fhanik requested review from duanemay and Kehrlann February 4, 2025 21:34
1. Supports running against local docker SAML container on
   http://localhost:9090/simplesaml

2. Set system property -Dintegration.test.saml.url=http://localhost:9090/simplesaml
   Either during gradle run or IDE

3. uaa-acceptance SAML is an older version, some URLs changed
   This is handled automatically
   This is handled automatically
   This is handled automatically
   This is handled automatically
@fhanik fhanik force-pushed the pr/saml-via-docker branch from 3c38672 to 5b3cd36 Compare February 4, 2025 21:37
@fhanik fhanik marked this pull request as ready for review February 5, 2025 01:58
@fhanik fhanik requested a review from strehle February 5, 2025 03:42
Copy link
Contributor

@Kehrlann Kehrlann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the double commit, one for the container and one for the code.

@fhanik fhanik merged commit a88adc5 into cloudfoundry:develop Feb 5, 2025
22 checks passed
@fhanik fhanik deleted the pr/saml-via-docker branch February 5, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants