Introduce optional Cache for Login Info IdPs #3251
Open
+635
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianhoelzl-sap
force-pushed
the
introduce-cache-for-login-info-idps
branch
3 times, most recently
from
90eb364 to
07df897
Compare
|
I am not convinced about cache here... in the past there were several PR´s from you in order to optimize the logic and I thought now we don't have situations ( only error situations ) where all IdPs are fetched ( means select * from identity_provider XXX) Instead of caching IdPs I would work on #3145 and would Disable option |
adrianhoelzl-sap
force-pushed
the
introduce-cache-for-login-info-idps
branch
from
07df897 to
0a3e62d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a cache for the SAML or OAuth identity providers returned in the login info endpoint. By default, the cache is disabled.
If enabled, the cached IdPs are neither synchronized between the different UAA instances and are not invalidated whenever an IdP is created, updated or deleted. Therefore, during a cache period, the returned set might be inconsistent.