Refactoring to fix issue #3232 #3233
Open
+20
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strehle
force-pushed
the
fix/issue/3232
branch
2 times, most recently
from
9485cf2 to
5410f9d
Compare
Move the check for existing secrets to the grant flow (runtime) and remove it from REST (configuration). We support now private_key_jwt next to secret, so check all parts in REST is too less and will get complicated. Fix a potential security issue because we must not create a token based on no authentication
strehle
force-pushed
the
fix/issue/3232
branch
from
5410f9d to
092acdd
Compare
strehle
commented
Feb 5, 2025
| import static org.cloudfoundry.identity.uaa.oauth.token.TokenConstants.GRANT_TYPE_JWT_BEARER; | ||
|
|
||
| public class JwtTokenGranter extends AbstractTokenGranter { | ||
| final DefaultSecurityContextAccessor defaultSecurityContextAccessor; | ||
|
|
||
| private static final List<String> ALLOWED_AUTH_METHODS = List.of(CLIENT_AUTH_SECRET, CLIENT_AUTH_PRIVATE_KEY_JWT); | ||
| //comment I would add here CLIENT_AUTH_EMPTY to allow empty secret for jwt bearer, same as allowed for password |
There was a problem hiding this comment.
With this, the change is not change but only a refactoring.
As mentioned currently we reject in clients for JWT bearer empty secret but that is strange and we should discuss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to fix issue #3232
Move the check for existing secrets to the
grant flow (runtime) and remove it from REST (configuration).
We support now private_key_jwt next to secret, so check all parts in REST is too less and will get complicated. Fix a potential security issue because we must not create a token based on no authentication