Fix go1.25 go vet and other minor cleanups #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Counterfeiter was bumped in earlier commits, but the fakes had not be updated since. The test-unit script regenerates the fakes so commit here to reduce noise from future local test runs.
go1.25 go vet fails on assembling a host:port using sprintf in a way that is not compatible with IPv6 addresses. Use net.JoinHostPort instead. Switch ioutil => io in a similar case to address other linter warnings while in the area.
ryanwittrup
force-pushed
the
chore/govet-125
branch
from
05f9723 to
fbb37b1
Compare
|
Rebased to get on top of the earlier PR for database user updates Everything here looks good, merging in |
github-project-automation
bot
moved this from Inbox
to Done
in Foundational Infrastructure Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor testing cleanups motivated by changes in [email protected] vet tooling that failed on a test file in galera-healthcheck while running the test-unit script.
Also committed some regenerated fakes that were rebuilt by the testing scripts - apparently a previous bump in counterfeiter slightly changed the fakes output.