[go-migration] Fix replacing of launcher class for spring-boot apps, refactor spring-boot container #1209
Open
kiril-keranov wants to merge 2 commits intocloudfoundry:feature/go-migrationfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JarLauncherfor spring-boot exploded jars. For example if another launcher is specified in the app manifest likeMain-Class: org.springframework.boot.loader.launch.PropertiesLauncherit will be replaced withorg.springframework.boot.loader.launch.JarLauncherfor spring-boot 3.x apps ororg.springframework.boot.loader.JarLauncherfor spring-boot 2.x apps when building the start command for this application. Seems this is due to some AI generation issue as the current buildpack comprises no such logic.spring-bootcontainer to prevent code duplication.-Xbootclasspath/a:removal with previous PR.