Repository navigation
fix(inigo): use TLS NATS (TNZ-1234) - #1221
Merged
Merged
Conversation
Gorouter no longer supports non-TLS NATS and fails to load its config when nats.ca_certs is empty. Inigo's componentMaker generated a gorouter config without TLS NATS. - Add NATS CA, server and client fixture certs (fixtures/certs/nats), generated by a new block in regenerate-certs.sh, and start nats-server with --tls and --tlsverify. - Give gorouter the NATS CA, client cert and client key as inline PEM, and set nats.tls_enabled so forks that still treat TLS as opt-in connect too. - Enable NATS TLS in the route-emitter config. ai-assisted=yes TNZ-1234
winkingturtle-vmw
approved these changes
Oct 21, 2026
geofffranks
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream routing-release commit 5e0558f removed non-TLS NATS support, so gorouter now fails to load its config when nats.ca_certs is empty. Inigo's componentMaker generated a gorouter config without TLS NATS.
ai-assisted=yes
TNZ-1234
Summary
Backward Compatibility
Breaking Change? No