fix: make container certificates compliant with X.501 standard#1178
Open
wpt1313 wants to merge 1 commit into
Open
fix: make container certificates compliant with X.501 standard#1178wpt1313 wants to merge 1 commit into
wpt1313 wants to merge 1 commit into
Conversation
Golang's `crypto/x509/pkix` does not generate X.501-compliant structure for multi-valued RDNs (see [1]). This commit provides a workaround for this bug: instead of `pkix.Name.OrganizationalUnits` it uses `ExtraNames` property which encodes each entry as a separate RDN (see [2]). --- [1] golang/go#40876 [2] https://github.com/golang/go/blob/release-branch.go1.27/src/crypto/x509/pkix/pkix.go#L249
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Golang's
crypto/x509/pkixdoes not generate X.501-compliant structure for multi-valued RDNs (see golang/go#40876), such as Organizational Unit (used here for app, space and org GUIDs). The difference can be easily identified e.g. withopenssl asn1parse. For the correct certificates, the relevant section looks like that (note that each OUSEQUENCEis in a separateSET):For the certificate created with Go crypto/x509, the same structure is different (both
SEQUENCEs are in a singleSET):That prevents some services (such as AWS IAM RolesAnywhere) from correctly parsing the certificate subject (in case of AWS RolesAnywhere, only the first OU, ie. app GUID, is retrieved).
Because the original Go library bug will not be fixed, this PR implements a workaround: instead of
pkix.Name.OrganizationalUnitsit usesExtraNamesproperty which encodes each entry as a separate RDN.Backward Compatibility
Breaking Change? No
Even though the certificate structure is changed, any existing libraries that worked with the non-compliant certificate should be also able to read the proper one.