Bump default key length to 2048 and change fingerprint to SHA1 #3555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIPS 140-2 mode requires keys at least 2048 bits length for RSA The use of MD5 hashes is not FIPS-compliant SHA1 fingerprints are already supported by diego-ssh: https://github.com/cloudfoundry/diego-ssh/blob/main/proxy/proxy.go#L367-L369
a-b
reviewed
Dec 14, 2023
philippthun
reviewed
Dec 15, 2023
philippthun
approved these changes
Dec 15, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS 140-2 mode requires keys at least 2048 bits length for RSA The use of MD5 hashes is not FIPS-compliant
SHA1 fingerprints are already supported by diego-ssh: https://github.com/cloudfoundry/diego-ssh/blob/main/proxy/proxy.go#L367-L369
Addresses part of the issues identified in: #3544