Skip to content

Use yaml instance instead of static variable to enable threadsaftey #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use yaml instance instead of static variable to enable threadsaftey #1246

wants to merge 2 commits into from

Conversation

LitschiW
Copy link

Fixes #1245

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 14, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

Lokowandtg
Lokowandtg approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Lokowandtg Lokowandtg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lokowandtg
Copy link
Contributor

We have the same coding in class ApplicationManifestUtilsCommon. Could you apply the changes there as well?

Lokowandtg
Lokowandtg approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Lokowandtg Lokowandtg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anthonydahanne
anthonydahanne approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@anthonydahanne anthonydahanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@Kehrlann Kehrlann self-assigned this May 28, 2025
@Kehrlann
Copy link
Contributor

Kehrlann commented Jun 10, 2025 •
edited
Loading

@LitschiW would you mind rebasing on top of main (rebase, not merge) before I merge this, please?

@Kehrlann
Copy link
Contributor

@LitschiW Additionally, this does not compile: ApplicationManifestUtils uses ApplicationManifestUtilsCommon#YAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydahanne anthonydahanne anthonydahanne approved these changes

@Lokowandtg Lokowandtg Lokowandtg approved these changes

Assignees

@Kehrlann Kehrlann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApplicationManifestUtilsV3#write is not threadsafe
4 participants
@LitschiW @Lokowandtg @Kehrlann @anthonydahanne