Add enable-identity-aware-routing ops-file (RFC0055)#1353
Conversation
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
There was a problem hiding this comment.
These new ops files must be unit-tested:
https://github.com/cloudfoundry/cf-deployment/blob/main/units/tests/standard_test/operations.yml
We should also move this ops files into the "experimental" folder for now. When the feature is mature, we can promote to regular ops files.
Questions:
- Should this feature be enabled in one of the cf-deployment validation environments?
- Are there integration tests planned for CATs? Or are there already tests in the routing test suite? -> yes, PR is already open: cloudfoundry/cf-acceptance-tests#1913
- Add enable-identity-aware-routing.yml and enable-identity-aware-routing-cflinuxfs5.yml to standard_test operations.yml - Add use-operator-provided-identity-routing-domain.yml to standard_test operations.yml - Document the three new operations in operations/README.md with their purposes and dependencies - Update semantic test to allow apps_identity_ca.certificate as an exception (alongside diego_instance_identity_ca.certificate) This is necessary because the identity-aware-routing operations define and reference their own CA certificate variable
Have added unit tests in: 4b71097
The spec and scope for the feature has been discussed at great length in: https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0055-identity-aware-routing-for-gorouter.md. Given all the affected components (except for docs, which is on my todo list) have open or merged PRs (which are being tracked here). I'm wondering for how long this feature should be marked as experimental? If even at al. All the planned scope for this feature is included in the open PRs, there is no follow on work planned.
Yes |
|
If this PR is merged first, we need to change the paths addressed in this pull request. |
Summary
Adds ops-files to enable RFC0055 app-to-app mTLS routing via
*.apps.identity.Files added
operations/enable-identity-aware-routing.ymloperations/enable-identity-aware-routing-cflinuxfs5.ymloperations/use-operator-provided-identity-routing-domain.ymloperations/example-vars-files/vars-use-operator-provided-identity-routing-domain.ymlWhat the main ops-file does
_.apps.identity→ router instance group*.apps.identity— client certs are verified against the existingdiego_instance_identity_ca,X-Forwarded-Client-Certis forwarded in Envoy format*.apps.identityon the router (newapps_identity_ca+apps_identity_router_tlsBOSH variables)apps_identity_caas a trusted cert in cflinuxfs4 app containers and Diego repUsage
Reference