Skip to content

FIPS validation: Ignore failing tests for now #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

jochenehret
Copy link
Contributor

WHAT is this change about?

Run tests in "try" block so that the deployment is always cleaned up and the pool is unclaimed.

What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...

Alana wants to execute the FIPS validation for each new commit or stemcell version without manually releasing the lock.

Please provide any contextual information.

#1140

Has a cf-deployment including this change passed cf-acceptance-tests?

  • [] YES
  • NO (but Concourse job is now green)

Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.

  • YES - please choose the category from below. Feel free to provide additional details.
  • NO

How should this change be described in cf-deployment release notes?

N/A

Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?

  • YES - please specify
  • NO

Does this PR make a change to an experimental or GA'd feature/component?

  • experimental feature/component
  • GA'd feature/component

Please provide Acceptance Criteria for this change?

Pipeline is green and pool is automatically unclaimed even if tests fail:
https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/fips-stemcell

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.

* run tests in "try" block so that the deployment is always cleaned up and the pool is unclaimed
@jochenehret jochenehret requested review from a team January 12, 2024 10:45
@jochenehret jochenehret merged commit 5131cb1 into develop Jan 12, 2024
@jochenehret jochenehret deleted the release_fips_lock_after_tests branch January 12, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants