FIPS validation: Ignore failing tests for now #1153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this change about?
Run tests in "try" block so that the deployment is always cleaned up and the pool is unclaimed.
What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
Alana wants to execute the FIPS validation for each new commit or stemcell version without manually releasing the lock.
Please provide any contextual information.
#1140
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
How should this change be described in cf-deployment release notes?
N/A
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
Pipeline is green and pool is automatically unclaimed even if tests fail:
https://concourse.wg-ard.ci.cloudfoundry.org/teams/main/pipelines/fips-stemcell
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!