Skip to content

Conversation

@joergdw
Copy link
Contributor

@joergdw joergdw commented Nov 1, 2025

This contains the "app-autoscaler"-changes for cloudfoundry/app-autoscaler-release#3652.

Current top-commit-id of that branch: "9ca68503e2f08bd8123df39b5722decb0fcde1bb"

This PR comes with the following changes:

  • Service-key-support
    • Introduce the necessary handling into the Bind-function of the broker.
    • Unit-tests
    • Divide the schema into three logical units for three different scenarios, where the "meta.schema.json" brings all of them together:
      • Creation of a service-key using the default-policy while enforcing the usage of the field schema-version (only allowed value: "0.9").
      • Creation of a service-key with explicitly set policy while enforcing the usage of the field schema-version.
      • All the other use-cases that have been supported until now allowing to skip the schema-version. This is for backwards-compatibility.
  • Multi-schema support for binding-requests:
    • Separate logic between request-handling and request-parsing. Introduce the interface BindRequestParser for request-parsers. This is an architectural improvement to simplify maintenance even for a growing variance and seconds the seperation of the internal representation of scaling-policies from their json-representation.
    • Adapt tests to the slighly changed error-messages. This is necessary to support the old schema as well. For acceptance-tests these changes are minimal.
  • Makefiles:
    • Fix usage of shell-styles
    • (Re-)Generate fakes and gorouterproxy only if relevant input-files have changed.
    • Fix dependencies (e.g. for autoscaler.test) and recipes.
    • Use programs provided by devbox instead of go run ….
    • Fix target clean.
  • Efficiency-improvement: Avoid parsing of the default credential-type for the communication with the metricsforwarder on each request.

Current top-commit-id of that branch: "9ca68503e2f08bd8123df39b5722decb0fcde1bb"
@joergdw joergdw changed the title Fetch state from aas-release-branch "service-key-creation" Creation of service-keys Nov 1, 2025
@joergdw joergdw force-pushed the service-key-creation branch from 3e0f6c3 to d02e286 Compare November 17, 2025 15:11
@joergdw joergdw marked this pull request as ready for review November 19, 2025 08:35
This commit does adaptions to a slightly modified output due to switching to a multi-version-schema.
@joergdw
Copy link
Contributor Author

joergdw commented Nov 20, 2025

All tests are green at the moment.

@joergdw joergdw force-pushed the service-key-creation branch from f822f53 to 58ae449 Compare November 26, 2025 15:05
@joergdw
Copy link
Contributor Author

joergdw commented Nov 27, 2025

The tests just got green for this revision. We had several flakiness-issues.

@joergdw joergdw force-pushed the service-key-creation branch from 47bde33 to 9e1fafb Compare December 1, 2025 08:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

@joergdw joergdw merged commit 4855d4a into main Dec 3, 2025
18 of 20 checks passed
@joergdw joergdw deleted the service-key-creation branch December 3, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants