remove gin and zap from test app #3930
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvestre
added
the
skip-dependency-postprocessing
silvestre
force-pushed
the
remove-gin-and-zap-from-test-app
branch
from
d98fb92 to
1c2947f
Compare
As an app-autoscaler developer I want to have as few dependencies as possible So that I don't have to watch out for so many vulnerabilities in unmaintained dependencies. # Fix As we already have two HTTP libraries (gorilla/mux and net/http) get rid of a third one for the test app (gin). # AI Disclaimer Prompted by the committer, most of the work was done by GitHub copilot.
As an app-autoscaler developer I want to have as few dependencies as possible So that I don't have to watch out for so many vulnerabilities in unmaintained dependencies. # Fix As we already have two log libraries (lager and slog) get rid of a third one for the test app (zap). # AI Disclaimer Prompted by the committer, most of the work was done by GitHub CoPilot.
silvestre
force-pushed
the
remove-gin-and-zap-from-test-app
branch
from
1c2947f to
f340b7f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As an app-autoscaler developer
I want to have as few dependencies as possible
So that I don't have to watch out for so many vulnerabilities in unmaintained dependencies.
Fix
AI Disclaimer
Prompted by the committer, most of the work was done by GitHub copilot.