(feature): Enable ScalingEngine in mtar deployment #3797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig map in metricsforwarder config
• Centralize database configuration logic into db.ConfigureDb and db.ConfigureStoredProcedureDb • Remove individual configurePolicyDb and configureBindingDb functions • Move DatabaseConfig struct to a new models.go file in the db package • Update calls to database configuration in both API and metrics forwarder to use the new centralized functions
• Change db.ConfigureDb calls to vcapReader.ConfigureDb for PolicyDb and BindingDb. • Introduce vcapReader.ConfigureStoredProcedureDb for handling stored procedure database configuration. • Remove ConfigureStoredProcedureDb and ConfigureDb from db/helper.go. • Update tests to reflect changes in database configuration methods.
…est in autoscaler config utils
- Import the "time" package in db.go for time.Duration usage. - Introduce DatabaseConfig struct in db.go with connection parameters. - Delete models.go, moving DatabaseConfig to db.go.
• Implement configuration loading for stored procedure database in config.go • Enable tests for stored procedure database when cred_helper_impl is set to default in config_test.go
…ting Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…tgenerator module with configuration and routes, and set default instances to 0 for new modules in autoscaler app.
… eventgenerator • Refactor LoadConfig to read from file and VCAP services • Add error variables for configuration loading issues • Introduce loadYamlFile and loadVcapConfig helper functions • Update tests with new configuration loading logic and VCAP reader mocks • Remove unused imports and adjust defaultConfig function signature
- Correct grammar in test descriptions for database configuration calls. - Change cred_helper_impl to 'stored_procedure' for storedProcedure_db service. - Remove redundant storedProcedureConfig and read directly from VCAP services. - Remove outdated tests related to default cred_helper_impl for storedProcedure_db.
… eventgenerator • Refactor LoadConfig to read from file and VCAP services • Add error variables for configuration loading issues • Introduce loadYamlFile and loadVcapConfig helper functions • Update tests with new configuration loading logic and VCAP reader mocks • Remove unused imports and adjust defaultConfig function signature
…enerator config • Implement ConfigureDb method in VCAPConfiguration to set database URL • Use ConfigureDb to configure PolicyDb and AppMetricsDb in eventgenerator • Add AppMetricsDb constant to db package • Update tests to reflect changes in database configuration methods
…ventgenerator • Update DBConfig and DatabaseConfig struct references to use pointers in eventgenerator_suite_test.go and main.go. • Change struct field names from DB to Db and PolicyDB to PolicyDb, AppMetricDB to AppMetricDb to align with Go naming conventions.
…Db in eventgenerator
- Update eventgenerator configuration to use pointers for optional structs and add JSON tags - Modify eventgenerator test suite to handle CF environment variables and dynamically set config - Adjust eventgenerator main.go to load and validate config with VCAP services support - Implement ToJSON method in config.go for marshaling configuration to JSON - Change environment variable keys in mta.tpl.yaml to uppercase and use placeholders for Go version
• Introduce eventgenerator_health_password in build-extension-file.sh for event generator health checks. • Add eventgenerator-config resource with basic auth password in mta.tpl.yaml. • Implement configureMetricsCollectorTLS function in eventgenerator/config/config.go to load TLS configuration for the metrics collector from logcache-client. • Update eventgenerator unit tests to reflect new TLS configuration loading. • Remove scaling engine and metric collector TLS configs from default_config.json, streamline cf_server and db configurations. • Add logcache-client as a user-provided service in mta.tpl.yaml.
…e-cf-services.yml
- Introduce pool configuration to manage eventgenerator node count and index - Remove commented-out XFCC and route registration configurations - Implement instance index and space/org GUID retrieval in configutil - Adjust eventgenerator main.go to use new pool configuration - Update tests and default JSON config to reflect changes
bonzofenix
changed the title
bonzofenix
force-pushed
the
885-enable-scalingengine-via-mtar
branch
13 times, most recently
from
5242e4a to
85a4f24
Compare
bonzofenix
force-pushed
the
885-enable-scalingengine-via-mtar
branch
from
678356b to
6ab0a78
Compare
bonzofenix
force-pushed
the
877-enable-operator-via-mtar
branch
from
8172aa9 to
8e9e6ab
Compare
• Remove unused databaseNames declaration from top-level scope • Declare databaseNames within the relevant BeforeEach block in tests
…ction in autoscaler
…_* exports in build-extension-file.sh
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.