Skip to content

thomasgauvin: add logs for remote/local for kv operations #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thomasgauvin
Copy link
Contributor

@thomasgauvin thomasgauvin requested review from a team as code owners March 25, 2025 17:23
Copy link

changeset-bot bot commented Mar 25, 2025

🦋 Changeset detected

Latest commit: 217a2b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thomasgauvin thomasgauvin force-pushed the thomasgauvin-improve-kv-logging-remote-local branch from abb117e to 0679279 Compare March 25, 2025 17:31
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 25, 2025
Copy link
Contributor

github-actions bot commented Mar 25, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-wrangler-8665

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8665/npm-package-wrangler-8665

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-wrangler-8665 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-workers-bindings-extension-8665 -O ./cloudflare-workers-bindings-extension.0.0.0-va71d26745.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va71d26745.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-create-cloudflare-8665 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-kv-asset-handler-8665

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-miniflare-8665

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-pages-shared-8665

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-unenv-preset-8665

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-vite-plugin-8665

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-vitest-pool-workers-8665

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-workers-editor-shared-8665

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-workers-shared-8665

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14070239883/npm-package-cloudflare-workflows-shared-8665

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250320.0
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@thomasgauvin thomasgauvin force-pushed the thomasgauvin-improve-kv-logging-remote-local branch from 0679279 to 217a2b2 Compare March 25, 2025 21:14
@CarmenPopoviciu
Copy link
Contributor

this is looking good, just need to make sure the relevant tests are updated to get them 🍏

@emily-shen
Copy link
Contributor

closing in favour of #8746 (which standardises local/remote resource logging, updates tests, doesn't log where only json output is expected etc.)

@emily-shen emily-shen closed this Apr 1, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants