Skip to content

Use simdutf for remaining base64 decodes#6847

Open
Brooooooklyn wants to merge 1 commit into
cloudflare:mainfrom
Brooooooklyn:optimize-simd-base64-decode
Open

Use simdutf for remaining base64 decodes#6847
Brooooooklyn wants to merge 1 commit into
cloudflare:mainfrom
Brooooooklyn:optimize-simd-base64-decode

Conversation

@Brooooooklyn

Copy link
Copy Markdown

Summary:

  • Replace global atob() decoding with simdutf::base64_to_binary while preserving the existing InvalidCharacterError behavior.
  • Replace DataUrl's KJ base64 decode with a compatibility-preserving base64 alphabet filter followed by simdutf decoding.
  • Update the data-url Bazel target to depend directly on @simdutf and drop the unused encoding implementation dependency.

Tests:

  • git diff --check
  • Temporary C++ harness against simdutf v9.0.0 covering selected DataUrl/atob edge cases: extra padding, interior '=', garbage bytes, Unicode bytes, and base64url characters
  • Not run: bazel test targets locally because bazel is not installed on this PATH

@Brooooooklyn Brooooooklyn requested review from a team as code owners June 29, 2026 09:38
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Brooooooklyn Brooooooklyn force-pushed the optimize-simd-base64-decode branch from 7f2d2c7 to f7585ee Compare June 29, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant