feat: add access context types#6735
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6735 +/- ##
==========================================
- Coverage 66.62% 66.61% -0.01%
==========================================
Files 402 402
Lines 115914 115937 +23
Branches 19425 19428 +3
==========================================
+ Hits 77226 77230 +4
- Misses 27095 27111 +16
- Partials 11593 11596 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
petebacondarwin
left a comment
There was a problem hiding this comment.
Feels like we need to run the snapshots against clean main to remove the extra unexpected types?
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Signed-off-by: Matt Provost <mprovost@cloudflare.com>
Merging this PR will improve performance by 13.76%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | Encode_ASCII_256[TextEncoder][0/0/256] |
3.1 ms | 2.7 ms | +13.76% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing BSFishy:add-access-types (822a381) with main (ac31559)
Footnotes
-
129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
this should be more in line with workerd architecture. we separate the polymorphism to something that AccessContext wraps around rather than having AccessContext itself be polymorphic. Signed-off-by: Matt Provost <mprovost@cloudflare.com>
petebacondarwin
left a comment
There was a problem hiding this comment.
Reviewed for typings
Replaces #6413 and #6549.
Adds types for Cloudflare Access integration into Workers