Migrate to capnp-es #3927
Merged
Migrate to capnp-es #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Apr 11, 2025
penalosa
force-pushed
the
capnp-es
branch
2 times, most recently
from
015d807 to
f75c3c8
Compare
fhanau
approved these changes
Apr 17, 2025
anonrig
approved these changes
Apr 28, 2025
penalosa
commented
Apr 28, 2025
|
The generated output of |
|
We need to update node and types/node on EW as well |
|
@anonrig what's the process for that? |
Opening a branch on EW with the same branch name as this one, updating workerd git hash, and updating node and types/node. Once that build passes you can rerun the internal-build github action which will pick up your branches changes rather than an automated branch. Once this Pr lands you can land the EW change. |
edmundhung
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of cloudflare/workers-sdk#7788, fixes https://jira.cfdata.org/browse/DEVX-1599. This migrates the type generation system in
workerdto usecapnp-es. Notably, this should have no changes to the actually generated types, which should give us confidence that this is working as expected.