fix: use normalizePathSeparators in formatAppFilePath for Windows compatibility#2426
Merged
james-elicx merged 1 commit intoJun 30, 2026
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatAppFilePathinapp-route-graph.tswas using inline.replace(/\\\\/g, "/")to normalize path separators instead of the sharednormalizePathSeparatorsutility already imported at the top of the file.This fixes two call sites within
formatAppFilePath:normalizePathSeparatorswas already imported and used inscanWithExtensions(file-matcher.ts) for the same reason — this migrates the remaining per-callsite inline replacements inapp-route-graph.tsto the shared utility, consistent with how #1578 and #1604 addressed the same class of bug elsewhere.