Merged
Conversation
Member
|
As we are on it, let's rename the |
e2a3ec8 to
bde6630
Compare
977c5b3 to
394ed8a
Compare
Member
sergeychernyshev
left a comment
There was a problem hiding this comment.
My tests fail locally for some reason - not sure why they run in CI ;(
Still looking through the rest of the code - will submit more comments later today.
sergeychernyshev
previously approved these changes
Feb 10, 2026
Member
sergeychernyshev
left a comment
There was a problem hiding this comment.
None of these are critical changes, I believe so if you feel like making follow-up tickets for improving types so we can deal with it later, it's fine with me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All .js files converted to .ts:
New TypeScript Config Files:
package.json changes:
Other:
All CLI tests now reference dist/src/cli.js instead of cli.js
Updated CLI Args to use slice (non-mutating) instead of splice (mutating)
Cleanup test method in src/testRunner.ts is now async and closes the browser instance before removing temp files to prevent Jest open handles
Resolves Typechecking #104