test: verify visible automatic bonk wrapper#360
Closed
geoquant wants to merge 6 commits intocloudflare:mainfrom
Closed
test: verify visible automatic bonk wrapper#360geoquant wants to merge 6 commits intocloudflare:mainfrom
geoquant wants to merge 6 commits intocloudflare:mainfrom
Conversation
Contributor
|
/bonk review Triggered automatically for this PR. |
commit: |
Contributor
There was a problem hiding this comment.
LGTM. The automatic Bonk workflow changes are correctly implemented:
Security: Proper use of pull_request_target with NO_PUSH token permissions for auto-reviews; draft PRs are skipped.
Architecture: The wrapper pattern (bonk-check.yml → bonk.yml via workflow_dispatch) cleanly separates event handling from review execution.
UX: Visible /bonk comment provides transparency about automated activity.
Test file: The smoke test markdown is appropriate for this workflow validation PR.
Contributor
Docs PreviewCommit: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third smoke-test PR for the automatic Bonk workflow.
This PR targets
mainso the smoke test reflects the real protected-branch flow. The wrapper workflow will be triggered manually from the feature branch workflow definition to verify the intended visible UX before merge.Expected behavior for this smoke test:
/bonk reviewcomment appears on the PR/bonkmainbranch protections until the legacy required checks are addressed