Skip to content

feat: add CloudflareIcon and sprite generation pipeline#351

Open
geoquant wants to merge 6 commits intocloudflare:mainfrom
geoquant:geoquant/kumo-icons
Open

feat: add CloudflareIcon and sprite generation pipeline#351
geoquant wants to merge 6 commits intocloudflare:mainfrom
geoquant:geoquant/kumo-icons

Conversation

@geoquant
Copy link
Copy Markdown
Collaborator

@geoquant geoquant commented Apr 2, 2026

Adds CloudflareIcon, the generated sprite/name pipeline behind it, docs/demos, and warning-only SVG asset validation.

This gives us a Kumo-native path to begin deprecating @cloudflare/component-icon, which appears in 1279 import statements in Stratus today.

Review scope note:

  • 518 files changed total
  • 497 are committed source SVG assets
  • 1 is the generated sprite SVG
  • 2 are generated non-SVG files
  • 18 are authored, non-generated, non-SVG files

Validation:

  • pnpm lint
  • pnpm typecheck
  • pnpm --filter @cloudflare/kumo validate:changeset
  • cd packages/kumo-docs-astro && pnpm astro build

  • Reviews
    • bonk has reviewed the change
    • automated review not possible because:
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 2, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@351

commit: a7ad104

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Docs Preview

View docs preview

Commit: a7ad104

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Visual Regression Report

16 screenshot(s) with visual changes:

Button / Basic

178 px (0.18%) changed

Before After Diff
Before After Diff

Button / Variant: Secondary

314 px (0.31%) changed

Before After Diff
Before After Diff

Button / Loading State

11 px (0.01%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

200 px (0.2%) changed

Before After Diff
Before After Diff

Dialog / Dialog Basic

114 px (0.11%) changed

Before After Diff
Before After Diff

Dialog / Dialog Confirmation

1,566 px (1.54%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

244 px (0.24%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Combobox

225 px (0.22%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

130 px (0.13%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Basic

496 px (0.49%) changed

Before After Diff
Before After Diff

Select / Select Without Label

103 px (0.1%) changed

Before After Diff
Before After Diff

Select / Select With Field

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

505 px (0.5%) changed

Before After Diff
Before After Diff

Select / Select Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select (Open)

137 px (0%) changed

Before After Diff
Before After Diff
15 screenshot(s) unchanged
  • Button / Variant: Primary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Button / Title
  • Dialog / Dialog Alert
  • Select / Select Placeholder
  • Select / Select Custom Rendering
  • Select / Select Multiple
  • Select / Select Complex

Generated by Kumo Visual Regression

@geoquant
Copy link
Copy Markdown
Collaborator Author

geoquant commented Apr 2, 2026

/bonk

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 2, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 2, 2026

@geoquant Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant