Add unix domain socket for telemetry server #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpgabriel
force-pushed
the
unix-domain-sockets
branch
from
8c9c1c3 to
bfd5bcb
Compare
nox
approved these changes
Aug 13, 2025
zakcutner
reviewed
Aug 13, 2025
gpgabriel
force-pushed
the
unix-domain-sockets
branch
4 times, most recently
from
f9f3203 to
690a22f
Compare
zakcutner
reviewed
Aug 15, 2025
gpgabriel
force-pushed
the
unix-domain-sockets
branch
5 times, most recently
from
bc1350b to
abdb38b
Compare
zakcutner
approved these changes
Aug 18, 2025
nox
requested changes
Aug 19, 2025
marmeladema
reviewed
Aug 19, 2025
marmeladema
reviewed
Aug 19, 2025
marmeladema
reviewed
Aug 19, 2025
| if let Err(e) = std::fs::remove_file(path) { | ||
| log::warn!("failed to remove existing Unix socket file"; "path" => %path.display(), "error" => e); | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we really want to silently delete existing sockets? I have a gut feeling that this could hide subtle problems
There was a problem hiding this comment.
It would be easy to get into a bad state during a crash and a restart because we can't reuse old sockets.
gpgabriel
force-pushed
the
unix-domain-sockets
branch
from
abdb38b to
161ea12
Compare
nox
requested changes
Aug 20, 2025
gpgabriel
force-pushed
the
unix-domain-sockets
branch
from
161ea12 to
4f53c41
Compare
gpgabriel
force-pushed
the
unix-domain-sockets
branch
from
4f53c41 to
4b14aab
Compare
nox
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.