[Workers AI] Add Model Deprecations reference page with redirects#30768
[Workers AI] Add Model Deprecations reference page with redirects#30768mchenco wants to merge 2 commits into
Conversation
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
There was a problem hiding this comment.
Labels applied: , , .
Verdict: 1 suggestion to address before merge.
Summary of changes
- New data source tracking deprecated and planned-deprecation models.
- New reference page rendered via .
- now shows a caution banner on planned-deprecation model pages.
- Redirects added for 18 deprecated model URLs (+ updated target for existing redirect).
Issues
- MEDIUM line 41: The caution banner assumes the user arrived via a redirect ("You followed a link..."). This is inaccurate for visitors navigating directly to the reference page. See inline suggestion.
- Add deprecation data source (src/util/deprecated-models.ts) - Add reference page listing deprecated and planned-deprecation models (src/content/docs/workers-ai/platform/model-deprecations.mdx) - Add reusable content component (src/components/models/DeprecatedModelPage.astro) - Add deprecation banner on planned-deprecation model pages (src/components/models/ModelDetailPage.astro) - Redirect deprecated model URLs to reference page (public/__redirects)
|
Review summary: Verdict: 1 suggestion to address before merge. Summary of changes
Issues
|
9831c2f to
4290c07
Compare
|
Review complete. Labels applied: What changed
Issue flagged
Everything else looked solid: frontmatter is valid, redirect formatting is correct, the linked changelog entry exists, and MDX/component usage follows repo conventions. |
Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
|
Preview URL: https://67dd01e0.preview.developers.cloudflare.com Files with changes (up to 15) |
colbywhite
left a comment
There was a problem hiding this comment.
@mchenco , unfortunately, I don't think having a deprecation process built on publid/__redirects is going to work moving forward.
If I read this right, every model going forward that is deprecated by your team will require a change to public/__redirects, and thus will require review from @cloudflare/content-engineering (or @cloudflare/product-owners). I don't think you're looking to be bottlenecked like that.
There are other alternatives. If you really prefer the redirect strategy, you can dynamically redirect in your own file (ModelDetailPage perhaps?). I don't think we have a preference of your strategy, it just shouldn't involve public/__redirects.
Also, you currently have content collections in src/content/workers-ai-models/*.json and src/content/catalog-models/*.json. It might be easier for you to maintain long term if you put the deprecation info in the relevant json file. If you prefer to store the similar information in a TypeScript constant, be sure to add src/util/deprecated-models.ts to the code owners as owned by your team. And I think everything in src/components/models is AI-related as well, right? That's another one we likely want to get in the code owners file for your team.
Summary
Screenshots (optional)
Documentation checklist