DO: document deleteAll() now deletes alarms#28515
Conversation
|
This PR requires additional review attention because it affects the following areas: PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
/bonk perform a thorough review. make suggestions for any fixes. |
There was a problem hiding this comment.
Review of the deleteAll() alarm deletion documentation changes. Found a few issues — one likely build-affecting typo, a spelling fix, and a couple of style improvements.
Summary by severity:
- HIGH (1): Stray
gittext appended to end of line in partial — likely a copy-paste artifact that will render as visible junk text - MEDIUM (2): Typo "compatibiltiy" → "compatibility";
deleteAlarm()missing monospace formatting - LOW (2): Changelog title consistency (singular "alarm" vs plural used elsewhere); description could use "Clean up" instead of "Cleanup"
src/content/partials/durable-objects/api-storage-other-methods.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/durable-objects/best-practices/rules-of-durable-objects.mdx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,23 @@ | |||
| --- | |||
| title: deleteAll() now deletes Durable Object alarm | |||
There was a problem hiding this comment.
Minor: the title uses singular "alarm" but the rest of the PR (compatibility flag description, partial) uses plural "alarms". Consider pluralizing for consistency, since a Durable Object can have an active alarm that deleteAll() will delete.
| title: deleteAll() now deletes Durable Object alarm | |
| title: deleteAll() now deletes Durable Object alarms |
There was a problem hiding this comment.
/bonk Changelog should use singular "alarm" everywhere
src/content/changelog/durable-objects/2026-02-24-deleteall-deletes-alarms.mdx
Outdated
Show resolved
Hide resolved
|
Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
|
Review posted with 4 suggestions across 3 files. Here is the summary: Review SummaryHIGH (1):
MEDIUM (2):
LOW (2):
Overall the content changes are well-structured and technically sound. The compatibility flag file and the partial update correctly document the new behavior with appropriate fallback guidance for older compatibility dates. |
….mdx Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
…le-objects.mdx Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
…etes-alarms.mdx Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>
Co-authored-by: vy-ton <vy-ton@users.noreply.github.com>
|
Changed "alarms" to "the alarm" on line 19 of the changelog file. The changelog now consistently uses singular "alarm" throughout — matching the title on line 2 ("deletes Durable Object alarm") and the body on line 10 ("deletes a Durable Object alarm"). |
No description provided.