-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Documents connect being shut off when outbound worker is used #22554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated documentation to clarify the impact of enabling outbound workers on the connect() API functionality.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
f0357fd
to
98f3038
Compare
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Preview URL: https://98f3038f.preview.developers.cloudflare.com Files with changes (up to 15) |
@mikenomitch can I merge the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean you can't use hyperdrive when outbound workers are enabled?
glad we are documenting but this feels like just a bug, since afaik outbound workers were only ever intended to intercept fetch()
in the first place.
maybe another example of where pipelines and complexity that falls out from that hurts us
@dinasaur404 fyi for context re: bringing outbound workers to workers
Summary
When an outbound workers is on, the connect() API no longer works. This adds a note to the documentation explaining this.
In the long-run, we may add an outboundConnect-like API to allow the platform user to handle outbound TCP or allow them to turn it on/off with a toggle. If we do that, then this should be reverted or changed.
Screenshot
Documentation checklist