Add support for seanmonstar/warp web server framework
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok the first thing i need to ask to you is, can you rebase and bump the version to 0.3? |
|
Since you also added a sample, can you add it to the gh action where we run the tests? (you'll see it after the rebase) |
|
it should be rebased |
slinkydeveloper
requested changes
Nov 2, 2020
There was a problem hiding this comment.
I did a first pass to the docs and nits, I'm gonna try to look more thoroughly at the conversion code in the second pass, i need to learn a bit about warp APIs first.
Also, in the root readme of this repo, add the link to the crate and the link to the example as done for actix-web and its sample
slinkydeveloper
requested changes
Nov 2, 2020
slinkydeveloper
requested changes
Nov 3, 2020
Initial take on cloud events support for `seanmonstar/warp` Signed-off-by: Marko Milenković <[email protected]>
slinkydeveloper
approved these changes
Nov 4, 2020
|
Thanks @milenkovicm for this contribution! This is an awesome addition to this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial take on cloud events support for
seanmonstar/warpSigned-off-by: Marko Milenković [email protected]