Skip to content

Fix clippy warnings #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2021
Merged

Fix clippy warnings #134

merged 1 commit into from
Jun 29, 2021

Conversation

@jcrossley3
Copy link
Contributor

@jcrossley3 jcrossley3 commented Jun 28, 2021

I think these are mostly harmless. There are apparently good reasons for implementing Into instead of From, e.g. supporting older Rust versions, but according to clippy, From is preferred.

@jcrossley3
Fix clippy warnings
c1715d7 
Signed-off-by: Jim Crossley <[email protected]>
@slinkydeveloper slinkydeveloper merged commit 1a9d0d4 into cloudevents:master Jun 29, 2021
@slinkydeveloper slinkydeveloper added the enhancement New feature or request label Jun 29, 2021
@slinkydeveloper slinkydeveloper added this to the 0.4 milestone Jun 29, 2021
@jcrossley3 jcrossley3 deleted the clippy branch July 7, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

0.4

Development

Successfully merging this pull request may close these issues.

2 participants

@jcrossley3 @slinkydeveloper