Skip to content

Conversation

@ctron
Copy link
Contributor

@ctron ctron commented Mar 10, 2021

No description provided.

@ctron
Copy link
Contributor Author

ctron commented Mar 10, 2021

Looks like I broke a bunch of tests in PR #115 and the CI didn't show that (at least to me) … sorry for that, this should fix it.

@slinkydeveloper
Copy link
Member

@ctron any updates on this one? It seems to me, this still doesn't fix all the tests

@ctron
Copy link
Contributor Author

ctron commented Apr 21, 2021

@ctron any updates on this one? It seems to me, this still doesn't fix all the tests

I will take a look.

@ctron ctron force-pushed the feature/fix_tests_1 branch from 4324e04 to 7f96181 Compare April 21, 2021 08:09
@ctron ctron force-pushed the feature/fix_tests_1 branch from 7f96181 to fe7b580 Compare April 21, 2021 08:23
@slinkydeveloper slinkydeveloper added the bug Something isn't working label Apr 21, 2021
@slinkydeveloper slinkydeveloper added this to the 0.4 milestone Apr 21, 2021
@slinkydeveloper
Copy link
Member

Nice, thanks for fixing it!

@slinkydeveloper slinkydeveloper merged commit dfe2bcc into cloudevents:master Apr 21, 2021
@ctron
Copy link
Contributor Author

ctron commented Apr 21, 2021

Nice, thanks for fixing it!

Thanks for nagging me 😁 … I am sorry, I really forgot about this one.

@ctron ctron deleted the feature/fix_tests_1 branch April 21, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants