ClientLibrary: Retries for status code 423 and 503 #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
reviewed
Dec 5, 2025
Comment on lines
+82
to
+84
| case 423: | ||
| tflog.Debug(ctx, fmt.Sprintf("resource %s is locked, will try again, attempt=%d", request.resourceName, request.attempt)) | ||
| // Intentionally fall through to retry logic below |
Member
There was a problem hiding this comment.
If would be great to log a warning like we do for 400, with the message from the response:
terraform-provider-cloudamqp/api/api.go
Line 71 in fdc58f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
API backend will later start to respond with status 423 (locked) if server not configured.
Reference: #436
WHAT is this pull request doing?
Will later use generic retry, once they are migrated.
HOW was this pull request be tested?
Current VCR-test fixtures, no real attempt made.