fix: propagate channel errors to connection and handle channel close #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properly - Modify onerror handler in AMQPChannel to propagate errors to the connection level - Ensure channel errors are properly handled regardless of closure reason - Prevent propagation from connection channel (id=0) to avoid recursion 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
carlhoerberg
force-pushed
the
channel-error-handling
branch
from
d969fe6 to
afa527c
Compare
carlhoerberg
requested review from
dentarg,
baelter,
antondalgren and
ThomasSarlin
as code owners
carlhoerberg
commented
Jun 11, 2025
baelter
reviewed
Jun 12, 2025
src/amqp-channel.ts
Outdated
| if (closedByServer) this.onerror(err.message) | ||
|
|
||
| // Call onerror for any error, whether from server or from a channel operation | ||
| if (err.message !== "Connection closed by client") { |
There was a problem hiding this comment.
We cloud have our own Error class for this to make this check a bit more future proof.
antondalgren
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code