Skip to content
This repository was archived by the owner on Apr 17, 2024. It is now read-only.

Update bindings and ioctls for newest mshv driver updates #19

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

russell-islam
Copy link
Contributor

No description provided.

@russell-islam russell-islam requested a review from liuw June 18, 2021 01:14
@liuw
Copy link
Member

liuw commented Jun 18, 2021

The clippy warning can be fixed by copying the packed field out to a temporary variable. That way there is no reference created to it.

@russell-islam russell-islam force-pushed the muislam/update-hypervisor branch from a27a216 to 1079a91 Compare June 18, 2021 14:19
@liuw
Copy link
Member

liuw commented Jun 18, 2021

Upon further investigation, the warnings are for the generated test cases. We shouldn't manually change them. That's brittle and tedious.

I think we should ignore that class of warnings for now. I expect a new version of bindgen will fix those issues.

See also rust-lang/rust-bindgen#1651 and rust-lang/rust-bindgen#2064.

@russell-islam
Copy link
Contributor Author

Upon further investigation, the warnings are for the generated test cases. We shouldn't manually change them. That's brittle and tedious.

I think we should ignore that class of warnings for now. I expect a new version of bindgen will fix those issues.

See also rust-lang/rust-bindgen#1651 and rust-lang/rust-bindgen#2064.

For now I have suppressed the warnings with allowing it in the crate level.

@liuw liuw merged commit c2c3079 into master Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants