chore(deps): fix security vulnerabilities (form-data, undici, brace-expansion, fast-xml-parser, picomatch, uuid)#35
Conversation
Update six packages to patched versions: - form-data 4.0.4 -> 4.0.6 (GHSA-hmw2-7cc7-3qxx, high) - undici 5.29.0 -> 6.27.0 (multiple advisories, high) - brace-expansion -> 1.1.16 / 2.1.2 / 5.0.7 (GHSA-f886-m6hf-6m8v, GHSA-jxxr-4gwj-5jf2) - fast-xml-parser 5.5.12 -> 5.9.3 (GHSA-gh4j-gqv2-49f6) - picomatch 2.3.1 -> 2.3.2 (GHSA-3v7f-55p6-f55p, GHSA-c2c7-rcm5-vvqj, high) - uuid 8.3.2 -> 11.1.1 (GHSA-w5hq-g745-h8pq) Overrides changes: - Removed fast-xml-parser override: fix is now reachable in-range via @azure/core-xml@1.5.1, so it lives in the lock file only - Added undici override: @actions/http-client@2.x pins ^5.25.4 and no patched 5.x exists - Added uuid override: @azure/core-http pins ^8.3.0 and the fix only exists in >=11.1.1 form-data, brace-expansion, and picomatch fixes are lock-file-only in-range updates. All 77 tests pass.
build-and-test: Run #6
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
nsimonson
left a comment
There was a problem hiding this comment.
How does this get released? Do we need to run npm run all:action so the checked in dist is updated?
Run npm run package so the checked-in ncc bundle picks up the patched runtime deps (undici 6.27.0, form-data 4.0.6, fast-xml-parser 5.9.3, brace-expansion). Also remove orphaned chunk 851.index.js left over from a previous build (ncc does not clean the output dir; the new build emits 762.index.js instead).
build-and-test: Run #8
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
(Reply written by Claude, the AI assistant that prepared this PR — posted on Scott's behalf.) Good catch — yes. I've pushed a second commit (c19b4a8) that runs
|
Summary
Updates six transitive dependencies to patched versions to resolve security advisories:
Approach
Preference was given to lock-file-only updates over
overridesentries wherever the patched version was reachable within parent semver ranges:fast-xml-parser— updating@azure/core-xmlto 1.5.1 (in-range for@azure/storage-blob's^1.4.4) pulls fast-xml-parser^5.5.9→ 5.9.3, and the updated@aws-sdk/xml-builderdropped its fast-xml-parser dependency entirely. Verified the patched version survives a freshnpm installwithout the override.undici: ^6.27.0—@actions/http-client@2.xpins^5.25.4and no patched 5.x exists; verified removal of the override reverts the lock to vulnerable 5.29.0uuid: ^11.1.1—@azure/core-http(via@actions/artifact@4) pins^8.3.0and the fix only exists in ≥11.1.1; the alternative (@actions/artifact@6) is a breaking major upgrade, so the override is lower riskVerification
npm auditno longer reports any of the six packages (remaining findings are unrelated packages not in scope)Note
dist/contains the ncc-bundled action output (undici/uuid get bundled), sonpm run packageshould be run as part of the normal release flow to pick up the patched versions in the bundle.