Skip to content

Fix indentation of subforms within letfn #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions clj/dev-resources/test-special-case-indent.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
(let [x (fn [y] 1)]
(->> "ola"
(x)))

(letfn [(x [y] 1)]
(->> "ola"
(x)))

(->> "ola"
(x))

(defn foo []
(letfn [(x [y] 1)]
(->> "ola"
(x))))

(letfn [(twice [x]
(* x 2))
(six-times [y]
(* (twice y) 3))]
(println "Twice 15 =" (twice 15))
(println "Six times 15 =" (six-times 15)))

(letfn [(twice [x]
(* x 2))]
(->> "ola"
(x)))

(letfn [(foo [x y]
(->> x
y
:bar))
(twice [x]
(* x 2))
(six-times [y]
(* (twice y) 3))]
(foo #{:foo :bar :biz} :foo))

;; vim:ft=clojure:
39 changes: 39 additions & 0 deletions clj/dev-resources/test-special-case-indent.out
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
(let [x (fn [y] 1)]
(->> "ola"
(x)))

(letfn [(x [y] 1)]
(->> "ola"
(x)))

(->> "ola"
(x))

(defn foo []
(letfn [(x [y] 1)]
(->> "ola"
(x))))

(letfn [(twice [x]
(* x 2))
(six-times [y]
(* (twice y) 3))]
(println "Twice 15 =" (twice 15))
(println "Six times 15 =" (six-times 15)))

(letfn [(twice [x]
(* x 2))]
(->> "ola"
(x)))

(letfn [(foo [x y]
(->> x
y
:bar))
(twice [x]
(* x 2))
(six-times [y]
(* (twice y) 3))]
(foo #{:foo :bar :biz} :foo))

;; vim:ft=clojure:
5 changes: 5 additions & 0 deletions clj/test/vim_clojure_static/indent_test.clj
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,8 @@
(test-indent "dispatch macro indentation is handled correctly"
:in "test-dispatch-macro-indent.in"
:out "test-dispatch-macro-indent.out"))

(deftest test-special-case-indent
(test-indent "special case indentation is handled correctly"
:in "test-special-case-indent.in"
:out "test-special-case-indent.out"))
28 changes: 28 additions & 0 deletions indent/clojure.vim
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,35 @@ if exists("*searchpairpos")

call search('\S', 'W')
let w = s:strip_namespace_and_macro_chars(s:current_word())

if g:clojure_special_indent_words =~# '\V\<' . w . '\>'

" `letfn` is a special-special-case.
if w ==# 'letfn'
" Earlier code left the cursor at:
" (letfn [...] ...)
" ^

" Search and get coordinates of first `[`
" (letfn [...] ...)
" ^
call search('\[', 'W')
let pos = getcurpos()
let letfn_bracket = [pos[1], pos[2]]

" Move cursor to start of the form this function was
" initially called on. Grab the coordinates of the
" closest outer `[`.
call cursor(a:position)
let outer_bracket = s:match_pairs('\[', '\]', 0)

" If the located square brackets are not the same,
" don't use special-case formatting.
if outer_bracket != letfn_bracket
return 0
endif
endif

return 1
endif

Expand Down