Don't discard HEAD. Fixes #148 #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a good point. I'm not sure how middleware / jetty / content-encoding play together. I need to investigate further and study the RFC and jetty-adapter. |
|
According to latest RFC 7231 It sounds like liberator is doing the right thing but downstreams adapters incorrectly add the header. Maybe something to investigate with ring? |
|
Until #148 is clear, I will mark this as wont fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose another way of fixing this would be to compute the length as if for a GET and use that for the "Content-Length" but considering there might be middleware somewhere that alters it (e.g. gzip), it seems easier to just pass along the body and allow it to be dealt with at the edge.