Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add constructor info to arglists of Java classes #87

Closed
wants to merge 2 commits into from
Closed

WIP: Add constructor info to arglists of Java classes #87

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b17711e
Add constructor info for Java classes to :arglists in info op
yuhan0 Apr 5, 2020
15a056a
Abbreviate some common types in eldoc to reduce space
yuhan0 Apr 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/orchard/eldoc.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
in editors."
{:author "Bozhidar Batsov"})

(def ^:private type-abbrevs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go this route this should be something optional (and ideally something that clients can modify).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree - it should probably be a client-side processing step, eg. eldoc could do a search-and-replace via regex.

'{java.lang.Object obj
java.lang.String str})

(defn- extract-arglists
[info]
(cond
Expand All @@ -15,7 +19,8 @@
(mapcat :arglists)
distinct
(sort-by count))
:else (:arglists info)))
:else (for [arglist (:arglists info)]
(mapv #(get type-abbrevs % %) arglist))))

(defn- format-arglists [raw-arglists]
(map #(mapv str %) raw-arglists))
Expand Down