refactor: Remove dependency on regex_macro #13
Conversation
It was not used in stable at all, because it only works in nightly. Now that regex! is almost always slower¹ there's no reason to keep it in. ¹: rust-lang/regex#164
|
@kbknapp you probably have more insight here. Mind to review? |
|
Oh, I only now see I broke the build because I removed the If you like to have it around I can add it back. In any way, the test only failed because of the missing feature, not because of broken code. |
|
I now see that I left in the feature for clog-cli. I should not code that early before the first coffee. D'oh! |
This does not enable anything, but we keep it around nonetheless.
|
I added back the feature. Test should be green, but travis failed to install Rust nightly. Can someone re-kick the tests? And a release after that would be great, so my own project can depend on the Crates.io release again instead of the git repo |
|
Build has been restarted. Once it passes, should be good to go 👍 |
|
ping! |
|
Apologies I've been on vacation and forgot to recheck this. Looks good! |
refactor: Remove dependency on regex_macro
|
Any chance to get a release of the clog crate soon? |
It was not used in stable at all, because it only works in nightly.
Now that regex! is almost always slower¹ there's no reason to keep it in.
¹: rust-lang/regex#164