Bump rust toolchain to 1.98.1 - #5924
Open
coolreader18 wants to merge 5 commits into
Open
coolreader18 wants to merge 5 commits into
coolreader18 wants to merge 5 commits into
Conversation
coolreader18
requested review from
bfops,
cloutiertyler,
jdetter and
rekhoff
as code owners
September 10, 2026 17:40
coolreader18
force-pushed
the
noa/upd-rust-1.98
branch
2 times, most recently
from
September 10, 2026 18:01
faf6062 to
f3e4972
Compare
coolreader18
force-pushed
the
noa/upd-rust-1.98
branch
from
September 10, 2026 18:09
f3e4972 to
31d4f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
rust-analyzer was complaining about the toolchain version being too old for it to work properly. This also ups the MSRV; I think I recall that we decided that we generally want to keep that in sync with our toolchain file.
I also wrote a script to keep the various version numbers we have in dockerfiles and such in sync with the rust-toolchain file.
cc @clockworklabs/devops
API and ABI breaking changes
MSRV bump but I don't think we count that.
Rollback safety impact
n/a
Expected complexity level and risk
2
Testing
n/a (or, I'm not sure what this involves)