Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcode patch 1 #1627

Merged
merged 19 commits into from
Jun 20, 2019
Merged

Transcode patch 1 #1627

merged 19 commits into from
Jun 20, 2019

Conversation

clinton-hall
Copy link
Owner

Description

Allow custom nice command handling.
Add logging of errors from ffmpeg to enable debugging.

Fixes #1619 1619

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

User tested.

Checklist:

  • I have based this change on the nightly branch
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@clinton-hall
Copy link
Owner Author

Finally. I have CI working again (and it did catch a bug!)
Note:
https://developercommunity.visualstudio.com/content/problem/598264/known-issue-azure-pipelines-images-missing-sqlite3.html

This workaround can be removed at a later date (or potentially kept to force testing against a known python version).

Note the issue here was a broken sqlite installation within azure.

@clinton-hall clinton-hall merged commit 9f6c068 into nightly Jun 20, 2019
@clinton-hall clinton-hall deleted the Transcode-patch-1 branch June 20, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant